Argo Workflows chart 0.32.0 is missing changes in CRDs

[cmontemuino]

Describe the bug

According to the diff in argo-workflows project, the chart 0.32.0 is missing changes in CRDs.

Related helm chart

argo-workflows

Helm chart version

0.32.0

To Reproduce

Check the diff: argoproj/argo-workflows@v3.4.9...master

Affected files:

• argoproj.io_clusterworkflowtemplates.yaml
• argoproj.io_cronworkflows.yaml
• argoproj.io_workflows.yaml
• argoproj.io_workflowtasksets.yaml
• argoproj.io_workflowtemplates.yaml

forceFinalizerRemoval in artifactGC is especially important.

Expected behavior

CRDs are the same as in https://github.com/argoproj/argo-workflows repo

Screenshots

No response

Additional context

No response

[jmeridth]

@cmontemuino The changes you're speaking of:

• manifests/base/crds/full/argoproj.io_clusterworkflowtemplates.yaml
• manifests/base/crds/full/argoproj.io_cronworkflows.yaml
• manifests/base/crds/full/argoproj.io_workflows.yaml
• manifests/base/crds/full/argoproj.io_workflowtasksets.yaml
• manifests/base/crds/full/argoproj.io_workflowtemplates.yaml

Were all made to the full CRDs. Our argo-workflows helm chart CRDs are the minimal CRDs here which match the minimal CRDs upstream here. They are the same.

Local diff showing only diff is what we have at the top in the annotations

 ➜  argo-workflows git:(3.4.9) diff manifests/base/crds/minimal/argoproj.io_clusterworkflowtemplates.yaml ~/code/argo-helm/charts/argo-workflows/templates/crds/argoproj.io_clusterworkflowtemplates.yaml                       
 0a1,2
 > {{- if .Values.crds.install }}
 > {{- if or (.Values.server.clusterWorkflowTemplates.enabled) (.Values.controller.clusterWorkflowTemplates.enabled) }}
 4a7,13
 >   annotations:
 >     {{- if .Values.crds.keep }}
 >     "helm.sh/resource-policy": keep
 >     {{- end }}
 >     {{- with .Values.crds.annotations }}
 >       {{- toYaml . | nindent 4 }}
 >     {{- end }}
 36a46,47
 > {{- end }}
 > {{- end }}
 ➜  argo-workflows git:(3.4.9) diff manifests/base/crds/minimal/argoproj.io_cronworkflows.yaml ~/code/argo-helm/charts/argo-workflows/templates/crds/argoproj.io_cronworkflows.yaml                                             7:30:03
 0a1
 > {{- if .Values.crds.install }}
 4a6,12
 >   annotations:
 >     {{- if .Values.crds.keep }}
 >     "helm.sh/resource-policy": keep
 >     {{- end }}
 >     {{- with .Values.crds.annotations }}
 >       {{- toYaml . | nindent 4 }}
 >     {{- end }}
 40a49
 > {{- end }}
 ➜  argo-workflows git:(3.4.9) diff manifests/base/crds/minimal/argoproj.io_workflows.yaml ~/code/argo-helm/charts/argo-workflows/templates/crds/argoproj.io_workflows.yaml                                                     7:30:35
 0a1
 > {{- if .Values.crds.install }}
 4a6,12
 >   annotations:
 >     {{- if .Values.crds.keep }}
 >     "helm.sh/resource-policy": keep
 >     {{- end }}
 >     {{- with .Values.crds.annotations }}
 >       {{- toYaml . | nindent 4 }}
 >     {{- end }}
 55a64
 > {{- end }}
 ➜  argo-workflows git:(3.4.9) diff manifests/base/crds/minimal/argoproj.io_workflowtasksets.yaml ~/code/argo-helm/charts/argo-workflows/templates/crds/argoproj.io_workflowtasksets.yaml                                       7:30:58
 0a1
 > {{- if .Values.crds.install }}
 4a6,12
 >   annotations:
 >     {{- if .Values.crds.keep }}
 >     "helm.sh/resource-policy": keep
 >     {{- end }}
 >     {{- with .Values.crds.annotations }}
 >       {{- toYaml . | nindent 4 }}
 >     {{- end }}
 41a50
 > {{- end }}
 ➜  argo-workflows git:(3.4.9) diff manifests/base/crds/minimal/argoproj.io_workflowtemplates.yaml ~/code/argo-helm/charts/argo-workflows/templates/crds/argoproj.io_workflowtemplates.yaml                                     7:31:18
 0a1
 > {{- if .Values.crds.install }}
 4a6,12
 >   annotations:
 >     {{- if .Values.crds.keep }}
 >     "helm.sh/resource-policy": keep
 >     {{- end }}
 >     {{- with .Values.crds.annotations }}
 >       {{- toYaml . | nindent 4 }}
 >     {{- end }}
 35a44
 > {{- end }}

Those changes have no where to go. I did state this in the description of my PR for the upgrade here.

Are you experiencing an error? A bug?

[cmontemuino]

@jmeridth thanks for the clarification. I couldn't find a mention that minimal CRDs are included in the chart, but if that's the case, then this is not a bug.
I'm closing it.

[jmeridth]

@cmontemuino that is a fair point. Us mentioning that in the README is a good idea.

[demian711]

Hello.
Adding me to the thread as "forceFinalizerRemoval" would be useful.
We are facing a case where Workflows are not being deleted because of the finalizer, despite there are no pods nor nothing that should block the deletion of it