Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applicationSet.replicaCount not completely migrated #2260

Closed
patrickli-foxtel opened this issue Sep 11, 2023 · 0 comments · Fixed by #2261
Closed

applicationSet.replicaCount not completely migrated #2260

patrickli-foxtel opened this issue Sep 11, 2023 · 0 comments · Fixed by #2261
Labels
argo-cd bug Something isn't working

Comments

@patrickli-foxtel
Copy link
Contributor

Describe the bug

https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/templates/_helpers.tpl#L204 still references replicaCount exclusively. This should be using replicas instead. I guess #2214 has missed it.

Related helm chart

argo-cd

Helm chart version

5.46.0

To Reproduce

  1. Set applicationSet.replicas to 2.
  2. applicationsetcontroller.enable.leader.election in configmap/argocd-cmd-params-cm is set to false.

Expected behavior

applicationsetcontroller.enable.leader.election in configmap/argocd-cmd-params-cm is true.

Screenshots

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
argo-cd bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@yu-croco @patrickli-foxtel