Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service workflow-controller includes image digest in app.kubernetes.io/version label #2335

Closed
nushemto opened this issue Nov 7, 2023 · 0 comments · Fixed by #2342
Closed
Labels
argo-workflows bug Something isn't working

Comments

@nushemto
Copy link

nushemto commented Nov 7, 2023

Describe the bug

My values:

# tried setting the images.tag but it didn't help
#images:
#  tag: v3.5.0
controller:
  serviceLabels:
    app.kubernetes.io/version: "v3.5.0". # this is a workaround, it creates an additional same-key label and sets the "v3.5.0" without the digest. Without this, the label's value appears with the digest.
    testing: "1234"
  image:
    registry: 1234.dkr.ecr.us-west-2.amazonaws.com
    repository: third-party/argoproj/workflow-controller
    tag: v3.5.0@sha256:dda36f7a872f463a68df04d72755c086eb193fa1645e1f099f1670dd5f99a277
  metricsConfig:
    enabled: true
server:
  image:
    registry: 1234.dkr.ecr.us-west-2.amazonaws.com
    repository: third-party/argoproj/argocli
    tag: v3.5.0@sha256:608b6d532b6a1ad4ae82b1e05ee844eb2f4fffe90a8524421f95e9355a7e4be1
  secure: true
  authMode: sso

When rendering the chart the result is that the label app.kubernetes.io/version in workflow-controller is using controller.image.tag instead of the Chart app version.

I am not sure why, but only the workflow-controller Service is specifying that label in this way. See here

Related helm chart

argo-workflows

Helm chart version

3.5.0

To Reproduce

  1. Create a custom values file with the values I've shared above.
  2. Run helm template -f custom-values.yaml .
  3. Search for the kind: Service created for the workflow-controller and check its app.kubernetes.io/version label.

Expected behavior

Not to include the (full) image tag+digest as part of the label, only the Chart's App version, as is the case with all other resources.

Screenshots

Screenshot 2023-11-07 at 17 12 15

Additional context

No response

@nushemto nushemto added the bug Something isn't working label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-workflows bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants