From e8cef4e97a6a2f21b969f9dec37accaa9bc99025 Mon Sep 17 00:00:00 2001 From: Jonny Langefeld Date: Tue, 16 Jul 2024 17:25:38 -0700 Subject: [PATCH 1/3] Remove namespace from cluster scope resource A few resources I noticed had the namespace set for cluster scoped resources. Signed-off-by: Jonny Langefeld --- .../templates/argocd-applicationset/clusterrolebinding.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/charts/argo-cd/templates/argocd-applicationset/clusterrolebinding.yaml b/charts/argo-cd/templates/argocd-applicationset/clusterrolebinding.yaml index af6d52978..9dcae8d2b 100644 --- a/charts/argo-cd/templates/argocd-applicationset/clusterrolebinding.yaml +++ b/charts/argo-cd/templates/argocd-applicationset/clusterrolebinding.yaml @@ -3,7 +3,6 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRoleBinding metadata: name: {{ template "argo-cd.applicationSet.fullname" . }} - namespace: {{ include "argo-cd.namespace" . }} labels: {{- include "argo-cd.labels" (dict "context" . "component" .Values.applicationSet.name "name" .Values.applicationSet.name) | nindent 4 }} roleRef: From 1301ce5f6730d337d271eebb53eee59caa396729 Mon Sep 17 00:00:00 2001 From: Jonny Langefeld Date: Tue, 16 Jul 2024 17:27:32 -0700 Subject: [PATCH 2/3] Update clusterrole.yaml Signed-off-by: Jonny Langefeld --- charts/argo-cd/templates/argocd-applicationset/clusterrole.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/charts/argo-cd/templates/argocd-applicationset/clusterrole.yaml b/charts/argo-cd/templates/argocd-applicationset/clusterrole.yaml index 9c9b9193e..59f03a0bb 100644 --- a/charts/argo-cd/templates/argocd-applicationset/clusterrole.yaml +++ b/charts/argo-cd/templates/argocd-applicationset/clusterrole.yaml @@ -3,7 +3,6 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRole metadata: name: {{ include "argo-cd.applicationSet.fullname" . }} - namespace: {{ include "argo-cd.namespace" . }} labels: {{- include "argo-cd.labels" (dict "context" . "component" .Values.applicationSet.name "name" .Values.applicationSet.name) | nindent 4 }} rules: From 741c5665fa5b9b38cd5ba56d3d649cd2b17e8e4f Mon Sep 17 00:00:00 2001 From: Marco Maurer Date: Mon, 23 Sep 2024 18:02:27 +0200 Subject: [PATCH 3/3] chore: Apply changes from code review Signed-off-by: Marco Maurer --- charts/argo-cd/Chart.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/argo-cd/Chart.yaml b/charts/argo-cd/Chart.yaml index dbf4e1139..fdd67b103 100644 --- a/charts/argo-cd/Chart.yaml +++ b/charts/argo-cd/Chart.yaml @@ -3,7 +3,7 @@ appVersion: v2.11.6 kubeVersion: ">=1.23.0-0" description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes. name: argo-cd -version: 7.3.10 +version: 7.3.11 home: https://github.com/argoproj/argo-helm icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png sources: @@ -26,5 +26,5 @@ annotations: fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252 url: https://argoproj.github.io/argo-helm/pgp_keys.asc artifacthub.io/changes: | - - kind: changed - description: Bump argo-cd to v2.11.6 + - kind: fixed + description: Remove namespace field from cluster scoped resources