Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove deprecated -i for go build #2047

Merged
merged 2 commits into from
Nov 10, 2022
Merged

build: remove deprecated -i for go build #2047

merged 2 commits into from
Nov 10, 2022

Conversation

danielhelfand
Copy link
Contributor 

The -i flag installs the packages that are dependencies of the target.
The -i flag is deprecated. Compiled packages are cached automatically.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@danielhelfand
chore: remove deprecated -i for go build
b5480e4 
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 18, 2022 •
edited
Loading

Codecov Report

Base: 81.55% // Head: 81.55% // No change to project coverage 👍

Coverage data is based on head (825a03b) compared to base (3aa87aa).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2047   +/-   ##
=======================================
  Coverage   81.55%   81.55%           
=======================================
  Files         124      124           
  Lines       18929    18929           
=======================================
  Hits        15437    15437           
  Misses       2702     2702           
  Partials      790      790

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 90 days with no activity.

@zachaller
Merge branch 'remove-i' of github.com:danielhelfand/argo-rollouts int…
825a03b 
…o danielhelfand-remove-i

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.1% 3.1% Duplication

@zachaller zachaller changed the title chore: remove deprecated -i for go build build: remove deprecated -i for go build Nov 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Go Published Test Results

1 798 tests   1 798 ✔️  2m 31s ⏱️
   102 suites         0 💤
       1 files           0 ❌

Results for commit 825a03b.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

E2E Tests Published Test Results

    2 files      2 suites   1h 28m 22s ⏱️
  89 tests   86 ✔️ 3 💤 0 ❌
178 runs  172 ✔️ 6 💤 0 ❌

Results for commit 825a03b.

@zachaller zachaller merged commit 09a045a into argoproj:master Nov 10, 2022
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
@danielhelfand @zachaller @jandersen-plaid
chore: remove deprecated -i for go build (argoproj#2047)
f034c13 
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>

Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Co-authored-by: zachaller <zachaller@users.noreply.github.com>
Gallardot pushed a commit to Gallardot/argo-rollouts that referenced this pull request Nov 27, 2022
@danielhelfand @zachaller @Gallardot
chore: remove deprecated -i for go build (argoproj#2047)
3689fe6 
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>

Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Co-authored-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: Gallardot <tttick@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaller zachaller zachaller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielhelfand @zachaller