Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename temlateref to templateref #2154

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

muma378
Copy link
Contributor

@muma378 muma378 commented Jul 21, 2022

Signed-off-by: Xiao Yang muma.378@163.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Xiao Yang <muma.378@163.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
5.5% 5.5% Duplication

@muma378 muma378 changed the title cleanup: rename temlateref to templateref chore: rename temlateref to templateref Jul 21, 2022
@github-actions
Copy link
Contributor

Go Published Test Results

1 713 tests   1 713 ✔️  2m 29s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit 6ff9dc0.

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #2154 (6ff9dc0) into master (c4205e8) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2154      +/-   ##
==========================================
- Coverage   82.21%   82.19%   -0.02%     
==========================================
  Files         121      121              
  Lines       17865    17865              
==========================================
- Hits        14687    14684       -3     
- Misses       2413     2415       +2     
- Partials      765      766       +1     
Impacted Files Coverage Δ
rollout/templateref.go 82.98% <ø> (ø)
rollout/trafficrouting/istio/controller.go 50.81% <0.00%> (-1.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c1d8a...6ff9dc0. Read the comment docs.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

  1 files    1 suites   44m 58s ⏱️
88 tests 83 ✔️ 3 💤 2
90 runs  85 ✔️ 3 💤 2

For more details on these failures, see this check.

Results for commit 6ff9dc0.

@muma378
Copy link
Contributor Author

muma378 commented Aug 3, 2022

@zachaller hi, do I need to add any extra information?

@leoluz leoluz merged commit 731d55b into argoproj:master Aug 3, 2022
jenciso pushed a commit to jenciso/argo-rollouts that referenced this pull request Oct 25, 2022
Signed-off-by: Xiao Yang <muma.378@163.com>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
Signed-off-by: Xiao Yang <muma.378@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants