feat: rollback windows. Fixes #574

[alexef]

fixes: #574

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[github-actions]

Go Published Test Results

1 800 tests   1 800 ✔️  2m 30s ⏱️
   102 suites         0 💤
       1 files           0 ❌

Results for commit 4d32999.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

Base: 81.55% // Head: 81.58% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (4d32999) compared to base (8987009).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2394      +/-   ##
==========================================
+ Coverage   81.55%   81.58%   +0.02%     
==========================================
  Files         124      124              
  Lines       18931    18959      +28     
==========================================
+ Hits        15439    15467      +28     
  Misses       2702     2702              
  Partials      790      790              

Impacted Files	Coverage Δ
rollout/bluegreen.go	68.30% <100.00%> (ø)
rollout/canary.go	75.48% <100.00%> (ø)
rollout/sync.go	80.13% <100.00%> (+0.76%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

E2E Tests Published Test Results

    2 files      2 suites   1h 36m 2s ⏱️
  92 tests   87 ✔️ 3 💤 2 ❌
186 runs  178 ✔️ 6 💤 2 ❌

For more details on these failures, see this check.

Results for commit 4d32999.

♻️ This comment has been updated with latest results.

[alexef]

@jessesuen here's my first attempt at this. I went for the revision count option, the time based one can also be added later on

[zachaller]

Could you also add some e2e tests for this change? I would like to get the behavior tested there as well.

[alexef]

add some e2e tests for this change

will do. I also need to make sure unit tests cover changes so that build is green

[zachaller]

Can we also get a little bit of documentation on this as well? I will get this reviewed this week as well.

[alexef]

@zachaller / @jessesuen can you have another look at this?
We identified the issue that was preventing the windows from working for us, updated the code and the e2e and I believe now the feature is ready.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication