Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apache APISIX support. Fixes #2395 #2437

Merged
merged 9 commits into from
Dec 13, 2022
Merged

Conversation

Gallardot
Copy link
Contributor

@Gallardot Gallardot commented Nov 27, 2022

Fixes #2395

Integrate Apache APISIX Ingress Controller and argo-rollouts using APISIX's CRD

Signed-off-by: Gallardot tttick@163.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2022

Go Published Test Results

1 825 tests   1 825 ✔️  2m 30s ⏱️
   105 suites         0 💤
       1 files           0

Results for commit e66221e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2022

E2E Tests Published Test Results

    2 files      2 suites   1h 44m 31s ⏱️
  94 tests   83 ✔️ 3 💤 8
196 runs  182 ✔️ 6 💤 8

For more details on these failures, see this check.

Results for commit e66221e.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Base: 81.58% // Head: 81.66% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (e66221e) compared to base (998ab09).
Patch coverage: 92.05% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2437      +/-   ##
==========================================
+ Coverage   81.58%   81.66%   +0.08%     
==========================================
  Files         124      126       +2     
  Lines       18959    19110     +151     
==========================================
+ Hits        15467    15606     +139     
- Misses       2702     2710       +8     
- Partials      790      794       +4     
Impacted Files Coverage Δ
utils/defaults/defaults.go 89.10% <ø> (ø)
rollout/trafficrouting/apisix/apisix.go 90.40% <90.40%> (ø)
rollout/trafficrouting.go 76.22% <100.00%> (+0.74%) ⬆️
utils/apisix/apisix.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Gallardot <tttick@163.com>
Signed-off-by: Gallardot <tttick@163.com>
@zachaller zachaller self-requested a review December 1, 2022 14:48
@zachaller zachaller added this to the v1.4 milestone Dec 1, 2022
@zachaller
Copy link
Collaborator

Can we get a link on the docs page with a little blurb about apisix and how to set it up or use th examples. Just like the other traffic routers found here https://argoproj.github.io/argo-rollouts/features/traffic-management/

Also the examples that you have in getting-started could also go into the examples folder https://github.com/argoproj/argo-rollouts/tree/master/examples

Signed-off-by: Gallardot <tttick@163.com>
Signed-off-by: Gallardot <tttick@163.com>
Signed-off-by: Gallardot <tttick@163.com>
Signed-off-by: Gallardot <tttick@163.com>
Signed-off-by: Gallardot <tttick@163.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
* feat: Apache APISIX support

Signed-off-by: Gallardot <tttick@163.com>

* feat: Apache APISIX support

Signed-off-by: Gallardot <tttick@163.com>

* feat: Improve the apisix route

Signed-off-by: Gallardot <tttick@163.com>

* chore: add apisix doc and examples

Signed-off-by: Gallardot <tttick@163.com>

* chore: add apisix doc and examples

Signed-off-by: Gallardot <tttick@163.com>

* chore: add UT

Signed-off-by: Gallardot <tttick@163.com>

* doc: update README

Signed-off-by: Gallardot <tttick@163.com>

Signed-off-by: Gallardot <tttick@163.com>
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
* feat: Apache APISIX support

Signed-off-by: Gallardot <tttick@163.com>

* feat: Apache APISIX support

Signed-off-by: Gallardot <tttick@163.com>

* feat: Improve the apisix route

Signed-off-by: Gallardot <tttick@163.com>

* chore: add apisix doc and examples

Signed-off-by: Gallardot <tttick@163.com>

* chore: add apisix doc and examples

Signed-off-by: Gallardot <tttick@163.com>

* chore: add UT

Signed-off-by: Gallardot <tttick@163.com>

* doc: update README

Signed-off-by: Gallardot <tttick@163.com>

Signed-off-by: Gallardot <tttick@163.com>
Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
* feat: Apache APISIX support

Signed-off-by: Gallardot <tttick@163.com>

* feat: Apache APISIX support

Signed-off-by: Gallardot <tttick@163.com>

* feat: Improve the apisix route

Signed-off-by: Gallardot <tttick@163.com>

* chore: add apisix doc and examples

Signed-off-by: Gallardot <tttick@163.com>

* chore: add apisix doc and examples

Signed-off-by: Gallardot <tttick@163.com>

* chore: add UT

Signed-off-by: Gallardot <tttick@163.com>

* doc: update README

Signed-off-by: Gallardot <tttick@163.com>

Signed-off-by: Gallardot <tttick@163.com>
Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apache APISIX support
2 participants