Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove namespaced crds #2516

Merged
merged 3 commits into from
Jan 15, 2023

Conversation

sfenman
Copy link
Contributor

@sfenman sfenman commented Jan 13, 2023

Fixes: #2359
Removed CRDs installation in the namespaced installation.
Also added a small README inside the manifests directory. Please let me know if it needs some more information in it.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Manolis Sfendourakis <sfenmanolis@gmail.com>
Signed-off-by: Manolis Sfendourakis <sfenmanolis@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2023

Go Published Test Results

1 834 tests   1 834 ✔️  2m 30s ⏱️
   105 suites         0 💤
       1 files           0

Results for commit 9ebd6b4.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 81.70% // Head: 81.70% // No change to project coverage 👍

Coverage data is based on head (9ebd6b4) compared to base (3540032).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2516   +/-   ##
=======================================
  Coverage   81.70%   81.70%           
=======================================
  Files         126      126           
  Lines       19135    19135           
=======================================
  Hits        15634    15634           
  Misses       2708     2708           
  Partials      793      793           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2023

E2E Tests Published Test Results

    2 files      2 suites   1h 40m 6s ⏱️
  95 tests   88 ✔️ 3 💤 4
194 runs  184 ✔️ 6 💤 4

For more details on these failures, see this check.

Results for commit 9ebd6b4.

♻️ This comment has been updated with latest results.

@zachaller
Copy link
Collaborator

Can we also update https://argo-rollouts.readthedocs.io/en/stable/installation/ to mention the two different installation methods?

Signed-off-by: Manolis Sfendourakis <sfenmanolis@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfenman
Copy link
Contributor Author

sfenman commented Jan 14, 2023

Can we also update https://argo-rollouts.readthedocs.io/en/stable/installation/ to mention the two different installation methods?

Sure!

@zachaller zachaller merged commit 4b2f202 into argoproj:master Jan 15, 2023
kimfiedler pushed a commit to mbhatip/argo-rollouts that referenced this pull request Jan 16, 2023
* chore: Remove CRDs from namespaced installation

Signed-off-by: Manolis Sfendourakis <sfenmanolis@gmail.com>

* docs: Add README for manifests

Signed-off-by: Manolis Sfendourakis <sfenmanolis@gmail.com>

* docs: Update installation methods

Signed-off-by: Manolis Sfendourakis <sfenmanolis@gmail.com>

Signed-off-by: Manolis Sfendourakis <sfenmanolis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix namespace install including crd's
2 participants