-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump k8s deps to v0.25.8 #2712
Conversation
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
…-bump-k8s-dep Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2712 +/- ##
=======================================
Coverage 81.47% 81.47%
=======================================
Files 133 133
Lines 20154 20154
=======================================
Hits 16421 16421
Misses 2881 2881
Partials 852 852 ☔ View full report in Codecov by Sentry. |
…-bump-k8s-dep Signed-off-by: zachaller <zachaller@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is introducing CRD changes. Is this intentional? Not sure I understand why this is required to update k8s deps. Maybe better to break this in 2 separate PRs?
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The reason there are crd changes is because we embed upstream k8s specs into various rollout objects and so when upstream k8s add's new fields we get them added to our crd's as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* bump to v0.24.12 Signed-off-by: zachaller <zachaller@users.noreply.github.com> * bump to v0.26.3 Signed-off-by: zachaller <zachaller@users.noreply.github.com> * bump to v0.25.8 Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add new interface functions Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix wrong dep inclusion Signed-off-by: zachaller <zachaller@users.noreply.github.com> --------- Signed-off-by: zachaller <zachaller@users.noreply.github.com>
This just bumps the k8s deps, all the other changes where do to code gen and bringing in the new upstream specs etc.