Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update test and related docs for plugin name standard #2728

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

wilsonwu
Copy link
Member

@wilsonwu wilsonwu commented Apr 17, 2023

Checklist:

  • Plugin name standard related tests and docs need to be updated #2727 Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
@wilsonwu wilsonwu marked this pull request as draft April 17, 2023 02:56
@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023

Go Published Test Results

1 948 tests   1 948 ✔️  2m 36s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 01ea982.

♻️ This comment has been updated with latest results.

@wilsonwu wilsonwu marked this pull request as ready for review April 17, 2023 03:00
@wilsonwu
Copy link
Member Author

Because update the package name, so lint goes wrong, need review.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 26m 35s ⏱️
  96 tests   83 ✔️   5 💤   8
398 runs  364 ✔️ 20 💤 14

For more details on these failures, see this check.

Results for commit 01ea982.

♻️ This comment has been updated with latest results.

USERS.md Outdated Show resolved Hide resolved
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@zachaller
Copy link
Collaborator

Thanks for the PR it is a good idea to update these as well

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
6.7% 6.7% Duplication

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e7e45f7) 81.47% compared to head (01ea982) 81.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2728   +/-   ##
=======================================
  Coverage   81.47%   81.47%           
=======================================
  Files         133      133           
  Lines       20154    20154           
=======================================
  Hits        16421    16421           
  Misses       2881     2881           
  Partials      852      852           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zachaller zachaller merged commit ddce671 into argoproj:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants