Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get new httpRoutesI after removeRoute() to avoid duplicates. Fixes #2769 #2887

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

xinpureZhu
Copy link
Contributor

@xinpureZhu xinpureZhu commented Jul 14, 2023

fixes: #2769
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Go Published Test Results

1 991 tests   1 991 ✔️  2m 37s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 957060c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 25m 15s ⏱️
  97 tests   84 ✔️   5 💤   8
402 runs  369 ✔️ 20 💤 13

For more details on these failures, see this check.

Results for commit 957060c.

♻️ This comment has been updated with latest results.

Signed-off-by: xinpureZhu <xinpure@sina.cn>
@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.01 ⚠️

Comparison is base (c8cd968) 81.67% compared to head (957060c) 81.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2887      +/-   ##
==========================================
- Coverage   81.67%   81.67%   -0.01%     
==========================================
  Files         133      133              
  Lines       20193    20192       -1     
==========================================
- Hits        16493    16492       -1     
  Misses       2847     2847              
  Partials      853      853              
Impacted Files Coverage Δ
rollout/trafficrouting/istio/istio.go 75.78% <25.00%> (-0.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zachaller zachaller merged commit 3ddb9ef into argoproj:master Jul 14, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VirtualService not being cleaned when running a new deployment before the old one finishes
2 participants