Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): typo fix ("Secrete" -> "Secret") in secret informer #2965

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

bartsmykla
Copy link
Contributor

When reading the code I found this typo in the resource kind. I'm not sure how huge of an impact this bug has yet, as I'm not very familiar with the codebase and project.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
    • There are no tests I could adjust according to the fix
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.
    • I'm doing it personally

Signed-off-by: Bart Smykla <bartek@smykla.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fec76d6) 81.74% compared to head (c901a87) 81.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2965   +/-   ##
=======================================
  Coverage   81.74%   81.74%           
=======================================
  Files         134      134           
  Lines       20370    20370           
=======================================
  Hits        16652    16652           
  Misses       2861     2861           
  Partials      857      857           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Go Published Test Results

2 040 tests   2 040 ✔️  2m 41s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit c901a87.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

    4 files      4 suites   3h 31m 51s ⏱️
102 tests   89 ✔️   6 💤   7
418 runs  384 ✔️ 24 💤 10

For more details on these failures, see this check.

Results for commit c901a87.

@zachaller zachaller enabled auto-merge (squash) August 22, 2023 06:03
@zachaller zachaller merged commit 8fc9021 into argoproj:master Aug 22, 2023
22 checks passed
zachaller pushed a commit that referenced this pull request Aug 22, 2023
…2965)

fix: typo fix ("Secrete" -> "Secret") in secret informer

Signed-off-by: Bart Smykla <bartek@smykla.com>
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label Aug 22, 2023
@bartsmykla bartsmykla deleted the fix/typo-in-secret-informer branch August 23, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-1.6 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants