Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump golang to 1.20 #2910

Merged
merged 13 commits into from
Jul 28, 2023
Merged

chore: bump golang to 1.20 #2910

merged 13 commits into from
Jul 28, 2023

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Jul 27, 2023

This change bumps golang to 1.20 it also required a few other changes in order to work with golang 1.20 and the new go vet checks.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (8bed760) 81.72% compared to head (cb35848) 81.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2910      +/-   ##
==========================================
+ Coverage   81.72%   81.75%   +0.02%     
==========================================
  Files         133      133              
  Lines       20336    20336              
==========================================
+ Hits        16619    16625       +6     
+ Misses       2860     2855       -5     
+ Partials      857      856       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

Go Published Test Results

2 033 tests   2 033 ✔️  2m 40s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit cb35848.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 36m 31s ⏱️
102 tests   85 ✔️   6 💤 11
426 runs  385 ✔️ 24 💤 17

For more details on these failures, see this check.

Results for commit fcb6b89.

♻️ This comment has been updated with latest results.

@zachaller zachaller marked this pull request as ready for review July 28, 2023 14:30
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@zachaller zachaller requested a review from leoluz July 28, 2023 19:27
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
16.3% 16.3% Duplication

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller merged commit 44f9488 into argoproj:master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants