Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up work of #12413 and related issues, ensure pod finalizer get removed #12952

Closed
imliuda opened this issue Apr 18, 2024 · 0 comments
Closed
Labels
type/feature Feature request

Comments

@imliuda
Copy link
Contributor

imliuda commented Apr 18, 2024

Currently, a feature is introduced to solve 'pod deleted' issue, whichi is caused by kube-controller-manager garbage controller. But for now, there are risks that the finalizer cann't be removed (or not in time) in some cases, for example:

  1. manually delete workflows while controller is not running
  2. workflow-controller restart due to health check
  3. api rate-limiting

Here I have some suggestion to avoid that situation occurrs.

  • use workflow finalizer
  • use a cron to remove finalizer of finished pod periodicly

But both methods can't handle api rate-limiting, may an api priority mechanism may be introduced. Also, there may some other cases and solutions.

And, there may be other option, but not using finalizer. As we know, this caused by gc controller, we may make some change to let it sort by finished time. Or, we can let wait container not exist, but sleep for a while, once workflow-controller have captured the exit status of main container, we kill wait container.

@imliuda imliuda added the type/feature Feature request label Apr 18, 2024
@imliuda imliuda changed the title Follow up work of #12413 and related issues, ensure pod finalizer get removed Follow up work of https://github.com/argoproj/argo-workflows/pull/12413 and related issues, ensure pod finalizer get removed Apr 18, 2024
@imliuda imliuda changed the title Follow up work of https://github.com/argoproj/argo-workflows/pull/12413 and related issues, ensure pod finalizer get removed Follow up work of #12413 and related issues, ensure pod finalizer get removed Apr 18, 2024
@imliuda imliuda closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

1 participant