Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onExit scaffolding code #5502

Closed
simster7 opened this issue Mar 24, 2021 · 3 comments · Fixed by #6297
Closed

Remove onExit scaffolding code #5502

simster7 opened this issue Mar 24, 2021 · 3 comments · Fixed by #6297
Assignees

Comments

@simster7
Copy link
Member

simster7 commented Mar 24, 2021

// Previously we used `parentNodeDisplayName` to generate all onExit node names. However, as these can be non-unique
// we transitioned to using `parentNodeName` instead, which are guaranteed to be unique. In order to not disrupt
// running workflows during upgrade time, we first check if there is an onExit node that currently exists with the
// legacy name AND said node is a child of the parent node. If it does, we continue execution with the legacy name.
// If it doesn't, we use the new (and unique) name for all operations henceforth.

Remember to remove the scaffolding code referenced by this issue and created by #5486

@simster7 simster7 self-assigned this Mar 24, 2021
@simster7 simster7 removed their assignment May 6, 2021
@stale
Copy link

stale bot commented Jul 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 5, 2021
@terrytangyuan
Copy link
Member

@simster7 Is there also a decision on when to remove the scaffolding code?

@stale stale bot removed the wontfix label Jul 6, 2021
@simster7
Copy link
Member Author

simster7 commented Jul 6, 2021

I'll do it now, thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants