Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit namespaces for SSO serviceaccounts (Cluster-Install) #9572

Closed
svndan opened this issue Sep 10, 2022 · 1 comment
Closed

Limit namespaces for SSO serviceaccounts (Cluster-Install) #9572

svndan opened this issue Sep 10, 2022 · 1 comment
Labels
type/feature Feature request

Comments

@svndan
Copy link

svndan commented Sep 10, 2022

Summary

Currently, enabling SSO requires the Argo-Server Service Account to have Cluster Permission on Secrets and ServiceAccounts.
This is a potential security risk if the cluster includes additional, higher level configurations.

I did some research on code-basis and since the argo-server is already making use of 'ssoNamespace'. I think the changes required would only need a few adjustments on how the serviceaccounts are fetched, if an optional flag like "ssoNamespaces" would be implemented.

If you agree on this feature, I am more than happy to contribute.

Use Cases

We are currently evaluating between a cluster-wide or multiple, namespaced instances for Argo-Workflows.
Due to our team structure, we do not hold Cluster-Admin permissions. However, we do have support and a process of installing CRDs, Operators and carefuly picked out ClusterRoleBindings.

The ClusterRoleBindings may only include permissions related to the CRDs we create and other resources that do not compromise secrets.
Because of how the SSO works, the argo-server will scan all serviceaccounts and all secrets on cluster-scope.
Limiting the namespaces for the SSO would allow to set namespaced roleBindings and still allow a cluster-wide instance.


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@svndan svndan added the type/feature Feature request label Sep 10, 2022
@svndan
Copy link
Author

svndan commented Sep 13, 2022

Realized this is already covered in the new release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

1 participant