Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Pin buildx action version to fix release workflow #10471

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

terrytangyuan
Copy link
Member

This fixes the release workflow:

docker.io/***/workflow-controller:latest-linux-arm64 is a manifest list

https://github.com/argoproj/argo-workflows/actions/runs/4077164697/jobs/7026848613

Co-authored-by: Jesse Suen jesse@akuity.io

Signed-off-by: Yuan Tang terrytangyuan@gmail.com

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan enabled auto-merge (squash) February 5, 2023 04:53
@NikeNano NikeNano self-requested a review February 5, 2023 20:09
Copy link
Contributor

@NikeNano NikeNano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terrytangyuan
Copy link
Member Author

cc @alexec @sarabala1979

@terrytangyuan terrytangyuan merged commit ad39810 into argoproj:master Feb 6, 2023
@terrytangyuan terrytangyuan deleted the fix-release-wf branch February 6, 2023 22:29
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request Feb 9, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
GoshaDo pushed a commit to GoshaDo/argo-workflows that referenced this pull request Feb 9, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: goshado <goshatoo@gmail.com>
@korenyoni
Copy link

korenyoni commented Feb 13, 2023

It should be possible to use the latest buildx version and setting --provenance=false.

This flag, introduced in buildx 0.10 (~2 weeks ago) with a default of true, and as this comment explains, builds an OCI-compliant multi-platform image, resulting in a fat manifest and hence docker.io/***/workflow-controller:latest-linux-arm64 is a manifest list.

This is better long-term than pinning buildx indefinitely.

kim-codefresh pushed a commit to codefresh-io/argo-workflows that referenced this pull request Feb 13, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
Copy link
Member Author

Thanks. Would you like to submit a PR to upgrade it?

kim-codefresh added a commit to codefresh-io/argo-workflows that referenced this pull request Feb 13, 2023
ci: Pin buildx action version to fix release workflow (argoproj#10471)
@korenyoni
Copy link

Will give it a go if someone doesn't beat me to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants