From 816b3ad4b13168215593f59b5624f1b5c3bf95f7 Mon Sep 17 00:00:00 2001 From: Anton Gilgur Date: Thu, 4 Apr 2024 23:49:05 -0400 Subject: [PATCH] ci(deps): remove auto `yarn-deduplicate` on dependabot PRs - reverts 568941e et al - ultimately, it would produce PRs that would not be mergeable as checks would not run on commits `push`ed via GH Actions - so it was fundamentally unworkable and hadn't been tested properly (note the missing "Verification" in the PR) - I do not know a good solution or workaround to this, but as it doesn't work, it should be removed - If we find something workable in the future, it can be added then once it's had extensive testing Signed-off-by: Anton Gilgur --- .github/workflows/ci-build.yaml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/.github/workflows/ci-build.yaml b/.github/workflows/ci-build.yaml index d9ecbae22b07..25535c7cdef2 100644 --- a/.github/workflows/ci-build.yaml +++ b/.github/workflows/ci-build.yaml @@ -415,15 +415,6 @@ jobs: - run: yarn --cwd ui test - run: yarn --cwd ui lint - run: yarn --cwd ui deduplicate - # Deduplicate UI deps for dependabot PRs - - name: Commit deduplicated yarn.lock for Dependabot PRs - if: github.actor == 'dependabot[bot]' - run: | - git config --global user.name 'github-actions[bot]' - git config --global user.email 'github-actions[bot]@users.noreply.github.com' - git add ui/yarn.lock - git commit -s --allow-empty -m 'chore: deduplicate yarn.lock' - git push # if lint or deduplicate make changes that are not in the PR, fail the build - name: Check if lint & deduplicate made changes not present in the PR run: git diff --exit-code