Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install should include data #21

Open
cnweaver opened this issue Sep 10, 2020 · 2 comments
Open

Install should include data #21

cnweaver opened this issue Sep 10, 2020 · 2 comments
Assignees

Comments

@cnweaver
Copy link
Collaborator

Currently, at configure time we fix the paths in global.h to point to the source directory, and do not change them when we install this header. As a result, a user can build and install the library, but then have it break down if the source directory (with the only copy of the default data tables) is subsequently deleted. We should probably:

  1. Copy the data files to a suitable place like ${prefix}/share/nusquids
  2. Update the paths in global.h when installing it to point to the installed data
@cnweaver cnweaver self-assigned this Sep 10, 2020
@arguelles
Copy link
Owner

I think this is resolved in the dev branch, right @cnweaver ?

@cnweaver
Copy link
Collaborator Author

Correct, this is implemented on v1.11-dev; we may want to keep this open as a reminder until we merge that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants