Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The name is not really used and gets in the way #26

Closed
arichiardi opened this issue Jan 22, 2019 · 2 comments
Closed

The name is not really used and gets in the way #26

arichiardi opened this issue Jan 22, 2019 · 2 comments

Comments

@arichiardi
Copy link
Owner

I have noticed that the utility of having a name is not really high and moreover having to pass a :name key every time can be tricky - for instance when generating processors dynamically:

(defn journey-processor-tap
  [index command]
  (let [uuid (:uuid command)]
    [{:processor #(hash-map :response (get-in % [:journeys index])
                            :command command)
      :path [:journeys index]
      :name (str "hack-" uuid)}   ;; this should be improved))

If we passed the symbol of the function instead of the function itself we could auto generate the name for instance.

@ElChache
Copy link
Collaborator

Agree, the name should be optional. But I think it shouldn't be removed, as it can still can be used by helper function in order to replace impure steps with mocks when testing

@arichiardi
Copy link
Owner Author

Solved with #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants