New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text action menu is not supported #325

Open

tom5079 opened this issue May 26, 2019 · 1 comment

tom5079 commented May 26, 2019 •

edited

Loading

Text action menus without icon automatically go to the overflow section because of the line 178 in MenuView

List<MenuItemImpl> localActionItems = filter(mMenuItems, new MenuItemImplPredicate() {
	@Override
	public boolean apply(MenuItemImpl menuItem) {
		return menuItem.getIcon() != null && (menuItem.requiresActionButton() || menuItem.requestsActionButton());
	}
});

I don't think menuItem.getIcon() != null is nessesary because option always|withText without icon is possible

The text was updated successfully, but these errors were encountered:

Author

tom5079 commented May 26, 2019

BTW, is this repository even mantained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment