feat: implement dialog prompt and refactor #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As CDK seems to not attach
stdinintocredential_processwe need to have another way to input the MFA token manually (or by copy-paste from an Authenticator App): This PR adds support for GUI-based dialog prompt for MFA token.The GUI dialog is context aware and if token provided via Yubikey touch, the GUI dialog prompt will be “cancelled” (i.e. hidden & removed).
The GUI dialog prompt is enabled by default as it actually provides a nice UX, but users may disable it by providing
--disable-dialogconfiguration flag.Besides the new feature, some refactoring was done: Especially regarding passing configuration flags around.