Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cvp 2020 update #176

Merged
merged 9 commits into from
Apr 7, 2020
Merged

cvp 2020 update #176

merged 9 commits into from
Apr 7, 2020

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Apr 3, 2020 •
edited
Loading

Types of changes

  • New feature (non-breaking change which adds functionality)

Related Issue(s)

#129

Proposed changes

Add support of Cloudvision 2020

Checklist:

  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed (make linting and make sanity-lint).

@titom73 titom73 added type: enhancement New feature or request status: in-progress Currently under investigation or implementation state: accepted Issue is part of the development roadmap labels Apr 3, 2020
@titom73 titom73 added this to the v1.1 milestone Apr 3, 2020
@titom73
Copy link
Contributor Author

titom73 commented Apr 3, 2020 •
edited
Loading

Todo:

@titom73
Merge branch 'releases/v1.1.x' into issues/129-cvp-2020-update
e82a49a
@titom73
Update code for cvp 2020
1d149ff 
- Backport function from #158
- Backport function from #168
- Run Linting
- Ansible Linting

Linting output:
---------------

```
$ make linting
sh .github/pre-commit
Validating PEP8 compliance...
------------------------------------------------------------------------------------------------------------
  - Modules validation
Using config file ansible-cvp/pylintrc

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

------------------------------------------------------------------------------------------------------------
  - Module Utils validation
Using config file ansible-cvp/pylintrc

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)
```
@titom73
Remove local content for testing
d51a4bb
@titom73 titom73 marked this pull request as ready for review April 7, 2020 13:24
@titom73 titom73 merged commit 7195793 into releases/v1.1.x Apr 7, 2020
@titom73 titom73 deleted the issues/129-cvp-2020-update branch April 7, 2020 13:25
@titom73 titom73 added status: testing PR under testing and removed state: accepted Issue is part of the development roadmap status: in-progress Currently under investigation or implementation labels May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@titom73 titom73

@Hugh-Adams Hugh-Adams

Labels
status: testing PR under testing type: enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@titom73 @Hugh-Adams