Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to avoid configuring vni for vlan in eos_designs #1022

Closed
1 of 3 tasks
inetman28 opened this issue Jun 10, 2021 · 2 comments · Fixed by #1000
Closed
1 of 3 tasks

Add option to avoid configuring vni for vlan in eos_designs #1022

inetman28 opened this issue Jun 10, 2021 · 2 comments · Fixed by #1000
Assignees
Labels
role: eos_designs issue related to eos_designs role state: in-progress Currently work in progress type: enhancement New feature or request
Milestone

Comments

@inetman28
Copy link

inetman28 commented Jun 10, 2021

Issue Type

  • Template enhancement
  • Role enhancement
  • Documentation enhancement (avd.sh)

Is your feature request related to a problem? Please describe.

Arista AVD export type-2 and type-3 routes to EVPN fabric but this action is not needed by default. Only TYPE-5 must be advertised by default.

Describe the solution you'd like

For example, I created SVI 104 in VRF INFRA on switch DC1-ESW1 and DC1-ESW2 (they are located in the same MLAG domain).
After that, AVD created below config:

interface Vxlan1
   vxlan vlan 104 vni 10104
!
router bgp 65399
   vlan 104
      rd 11.11.110.5:10104
      route-target both 10104:10104
      redistribute learned
   !

Above configuration stretch VLAN 104 through EVPN Fabric. This behavior advertise EVPN MAC-IP and IMET (type-2 and type-3) routes to EVPN.

DC1-ESW1#show bgp evpn route-type mac-ip vni 10104
BGP routing table information for VRF default
Router identifier 11.11.110.5, local AS number 65399
Route status codes: s - suppressed, * - valid, > - active, E - ECMP head, e - ECMP
                    S - Stale, c - Contributing to ECMP, b - backup
                    % - Pending BGP convergence
Origin codes: i - IGP, e - EGP, ? - incomplete
AS Path Attributes: Or-ID - Originator ID, C-LST - Cluster List, LL Nexthop - Link Local Nexthop

          Network                Next Hop              Metric  LocPref Weight  Path
 * >     RD: 11.11.110.5:10104 mac-ip 001b.1700.0a01
                                 -                     -       -       0       i
 * >     RD: 11.11.110.5:10104 mac-ip 001b.1700.0a01 192.168.4.11
                                 -                     -       -       0       i
 * >     RD: 11.11.110.5:10104 mac-ip 001b.1700.0a01 192.168.4.12
                                 -                     -       -       0       i
 * >     RD: 11.11.110.5:10104 mac-ip 001c.7300.dc01
                                 -                     -       -       0       i

I think these actions are not needed by default. For example, if you disable that behavior, then each MLAG domain will have unique VLAN range 1-4094.

One suggestion to avoid this is create one more key:value to avoid this, for example: ExportedToEvpn: False

Describe alternatives you've considered

Create SVI inside host_vars with structured_configuration_prefix.

@ClausHolbechArista
Copy link
Contributor

In general I expect us to keep the current default behavior, since that will cover most customer scenarios. But I think it makes a lot of sense to add a knob per SVI to override this behavior. We will change a lot of the related logic in AVD3.0, so let us look at this one after the pending PRs for 3.0 has merged.

@ClausHolbechArista ClausHolbechArista added this to the v3.0.0 milestone Jun 11, 2021
@ClausHolbechArista ClausHolbechArista added role: eos_designs issue related to eos_designs role state: investigating investigating issue type: enhancement New feature or request labels Jun 11, 2021
@inetman28
Copy link
Author

inetman28 commented Jun 11, 2021

yes, you are right. The default behavior to advertise type2 and type3 routes is good. But it should has option to avoid advertising. it is my opinion.

@ClausHolbechArista ClausHolbechArista changed the title Don't stretch VLAN through EVPN by default Add option to avoid configuring vni for vlan in eos_designs Jun 16, 2021
@ClausHolbechArista ClausHolbechArista self-assigned this Jun 16, 2021
@ClausHolbechArista ClausHolbechArista added the state: in-progress Currently work in progress label Jun 16, 2021
@ClausHolbechArista ClausHolbechArista linked a pull request Jun 16, 2021 that will close this issue
13 tasks
@ClausHolbechArista ClausHolbechArista removed the state: investigating investigating issue label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_designs issue related to eos_designs role state: in-progress Currently work in progress type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants