Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(eos_designs): SVI profile information not accounted inside eos_designs #1567

Closed
1 task done
xaviramon opened this issue Mar 7, 2022 · 1 comment
Closed
1 task done
Labels
state: stale type: bug Something isn't working

Comments

@xaviramon
Copy link
Contributor

xaviramon commented Mar 7, 2022

Issue Summary

Under #1531 inheritance between SVI profiles is implemented.
During testing, it was detected that even when some values are defined in the SVI profile, it will never be applied to the SVI itself.
The SVI profile should work in a sense that anything that is defined inside them, they should be used in the SVI itself. Today's implementation prevents this behaviour, as eos_designs only looks at the SVI definitions and ignores the profile definitions.

Which component(s) of AVD impacted

eos_designs

How do you run AVD ?

Ansible CLI (with virtual-env or native python)

Steps to reproduce

Define a svi_profiles under network services:

svi_profiles:
  parent_profile_test:
    mtu: 1000
    enabled: true
  test1:
    name: "TEST1"
    enabled: true
    parent_profile: parent_profile_test

Then, define a SVI under a VRF without a value defined in the profile (name, in this example):

svis:
          51:
            description: "Des_VLAN51"
            profile: test1
            tags: [ every ]

Generation of the configuration will fail, complaining that "name" couldn't be found:

TASK [arista.avd.eos_designs : Generate device configuration in structured format] ************************************************************************************************
Monday 07 March 2022  11:35:15 +0100 (0:00:01.897)       0:00:09.941 ********** 
fatal: [POD1_LEAF01A -> localhost]: FAILED! => {"msg": "'dict object' has no attribute 'name'"}

Under debug-vars, we can see all information is filled in, but inside the profile:

svi_profiles:
  parent_profile_test:
    mtu: 1000
    enabled: true
  test1:
    name: TEST1
    enabled: true
    parent_profile: parent_profile_test
tenants:
  TENANT_A:
    enable_mlag_ibgp_peering_vrfs: true
    mac_vrf_vni_base: 10000
    vrfs:
      TENANT_A_VRF1:
        vrf_id: 1
        svis:
          51:
            description: Des_VLAN51
            profile: test1
            tags:
            - every

Relevant log output

No response

Contributing Guide

  • I agree to follow this project's Code of Conduct
@xaviramon xaviramon added the type: bug Something isn't working label Mar 7, 2022
@github-actions
Copy link

github-actions bot commented Jun 6, 2022

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: stale type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant