Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"container_inclusive" is disregarded on the selective refresh class #1089

Closed
daviedR opened this issue Aug 25, 2016 · 4 comments
Closed

"container_inclusive" is disregarded on the selective refresh class #1089

daviedR opened this issue Aug 25, 2016 · 4 comments
Assignees
@aristath
Labels
bug

Comments

@daviedR
Copy link

daviedR commented Aug 25, 2016

Hi Ari,

The "container_inclusive" argument is very important when you add a partial refresh. What you did in: https://github.com/aristath/kirki/blob/72ea3dc343706f02fc49702a9e90956c23c6c259/includes/class-kirki-selective-refresh.php#L49 makes it impossible to pass the "container_inclusive" argument to the native WordPress Selective Refresh API.

Can you take a look at it?
@aristath aristath self-assigned this Aug 25, 2016
@aristath aristath added the bug label Aug 25, 2016
@aristath
Copy link
Contributor

You're absolutely right...
Marking as a bug, I'll take a look.

@aristath
Copy link
Contributor

I think this last commit in the develop branch fixes the issue but didn't have any time to test, can you please verify that it works for you?

@daviedR
Copy link
Author

daviedR commented Aug 26, 2016

Hi Ari, just tested and it works perfectly. Thanks!

@aristath
Copy link
Contributor

👍 awesome, thanks for checking!
Will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aristath aristath

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aristath @daviedR