Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.3.2 use $l10n For Translation. #960

Closed
Hujjat opened this issue May 3, 2016 · 3 comments
Closed

Version 2.3.2 use $l10n For Translation. #960

Hujjat opened this issue May 3, 2016 · 3 comments
Labels

Comments

@Hujjat
Copy link

Hujjat commented May 3, 2016

Issue description:

I have just download the version 2.3.2 version of kikri. The previous had checkbox unchecked problem. Now check box is working but when I check my theme with theme checker, it gives the old error of $l10n variable for theme translation text.

Version used:

(Did you try using the develop branch from github? There's a chance your issue has already been adressed there)
Yes I use the latest version.

Using theme_mods or options?

theme_mods

Code to reproduce the issue (config + field(s))

RECOMMENDED: Possible variable $l10n found in translation function in class-kirki-controls-repeater-control.php. Translation function calls must NOT contain PHP variables.

thank's :)

@aristath
Copy link
Contributor

aristath commented May 3, 2016

👍 fixed in the latest develop branch.

@Hujjat
Copy link
Author

Hujjat commented May 4, 2016

Thank's hero,
one line remaining, :)
class-kirki-controls-repeater-control.php line 411. The Text-domain for Hex Value.

@aristath aristath reopened this May 9, 2016
@aristath
Copy link
Contributor

aristath commented May 9, 2016

Oops you're right... I missed that one. Fixed now 👍

@aristath aristath added the bug label May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants