Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring codeclimate up to A #4

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Bring codeclimate up to A #4

merged 2 commits into from
Jan 19, 2024

Conversation

arjunsavel
Copy link
Owner

Want to move from B-->A!

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (b417a6e) 64.52% compared to head (00d9230) 61.75%.
Report is 41 commits behind head on main.

Files Patch % Lines
src/cortecs/fit/metrics.py 13.04% 40 Missing ⚠️
src/cortecs/opac/io.py 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   64.52%   61.75%   -2.77%     
==========================================
  Files          17       17              
  Lines         761      821      +60     
==========================================
+ Hits          491      507      +16     
- Misses        270      314      +44     
Flag Coverage Δ
unittests 61.75% <35.82%> (-2.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arjunsavel arjunsavel merged commit 2571b52 into main Jan 19, 2024
5 checks passed
@arjunsavel arjunsavel deleted the refactoring branch January 19, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants