Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue refactoring for codeclimate #6

Merged
merged 13 commits into from
Jan 19, 2024
Merged

Continue refactoring for codeclimate #6

merged 13 commits into from
Jan 19, 2024

Conversation

arjunsavel
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (d73db64) 61.75% compared to head (539bf58) 62.54%.

Files Patch % Lines
src/cortecs/fit/metrics.py 28.57% 5 Missing ⚠️
src/cortecs/opac/io.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   61.75%   62.54%   +0.79%     
==========================================
  Files          17       17              
  Lines         821      841      +20     
==========================================
+ Hits          507      526      +19     
- Misses        314      315       +1     
Flag Coverage Δ
unittests 62.54% <90.16%> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arjunsavel
Copy link
Owner Author

Yeah, this is about as much refactoring as I can do right now 😅 merging!

@arjunsavel arjunsavel merged commit d04360a into main Jan 19, 2024
4 of 5 checks passed
@arjunsavel arjunsavel deleted the more_refactor branch January 19, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants