-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate away from llvm_asm
to asm
#305
Comments
We need to boost the urgency of this. As it appears that the latest version of Rust stable has deprecated it. |
#306 has mostly completed this, but it's currently segfaulting for some reason. Not sure why that's happening. |
@weikengchen This is the issue I mentioned during our meeting. Using the latest release of this repository 0.3.0 and using the nightly channel of Rust. I tried building the release locally as well as letting cargo take care of the package. Here is the dump output: edit: Note this dump was generated from attempting to run Gemini's docs. |
Got it. I think this is expected, as the nightly officially bans the llvm_asm. The stable version of Rust should be fine. There is still one remaining fix necessary for the #306. I will watch closely. |
Thanks. I was using nightly as rust complains about using in Gemini |
This seems to be a Gemini issue now, so we will discuss somewhere else. The fix is probably this: use nightly, and change the Cargo.toml of Gemini to remove "asm" from its default feature list. https://github.com/arkworks-rs/gemini/blob/main/Cargo.toml#L91 |
llvm_asm
is being deprecated: rust-lang/rust#87590The text was updated successfully, but these errors were encountered: