Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from llvm_asm to asm #305

Closed
Pratyush opened this issue Aug 11, 2021 · 6 comments · Fixed by #306
Closed

Migrate away from llvm_asm to asm #305

Pratyush opened this issue Aug 11, 2021 · 6 comments · Fixed by #306
Assignees
Labels
P-medium Priority: medium T-performance Type: performance improvements T-refactor Type: cleanup/refactor

Comments

@Pratyush
Copy link
Member

llvm_asm is being deprecated: rust-lang/rust#87590

@Pratyush Pratyush self-assigned this Aug 11, 2021
@Pratyush Pratyush added the T-feature Type: new features label Aug 11, 2021
@Pratyush Pratyush mentioned this issue Aug 12, 2021
6 tasks
@Pratyush Pratyush added P-medium Priority: medium T-performance Type: performance improvements T-refactor Type: cleanup/refactor and removed T-feature Type: new features labels Sep 9, 2021
@weikengchen
Copy link
Member

We need to boost the urgency of this. As it appears that the latest version of Rust stable has deprecated it.

@Pratyush
Copy link
Member Author

#306 has mostly completed this, but it's currently segfaulting for some reason. Not sure why that's happening.

@s7117
Copy link

s7117 commented Feb 4, 2022

@weikengchen This is the issue I mentioned during our meeting.

Using the latest release of this repository 0.3.0 and using the nightly channel of Rust.

I tried building the release locally as well as letting cargo take care of the package.

Here is the dump output:
dump.txt

edit: Note this dump was generated from attempting to run Gemini's docs.

@weikengchen
Copy link
Member

@weikengchen This is the issue I mentioned during our meeting.

Using the latest release of this repository 0.3.0 and using the nightly channel of Rust.

I tried building the release locally as well as letting cargo take care of the package.

Here is the dump output: dump.txt

edit: Note this dump was generated from attempting to run Gemini's docs.

Got it. I think this is expected, as the nightly officially bans the llvm_asm. The stable version of Rust should be fine.

There is still one remaining fix necessary for the #306. I will watch closely.

@s7117
Copy link

s7117 commented Feb 4, 2022

Got it. I think this is expected, as the nightly officially bans the llvm_asm. The stable version of Rust should be fine.

There is still one remaining fix necessary for the #306. I will watch closely.

Thanks. I was using nightly as rust complains about using in Gemini #![feature] on the stable release channel.
stable_dump.txt

@weikengchen
Copy link
Member

Got it. I think this is expected, as the nightly officially bans the llvm_asm. The stable version of Rust should be fine.
There is still one remaining fix necessary for the #306. I will watch closely.

Thanks. I was using nightly as rust complains about using in Gemini #![feature] on the stable release channel. stable_dump.txt

This seems to be a Gemini issue now, so we will discuss somewhere else.

The fix is probably this: use nightly, and change the Cargo.toml of Gemini to remove "asm" from its default feature list.

https://github.com/arkworks-rs/gemini/blob/main/Cargo.toml#L91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-medium Priority: medium T-performance Type: performance improvements T-refactor Type: cleanup/refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants