Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug impl of Fp outputs elements in Montgomery form. #76

Closed
Pratyush opened this issue Jun 19, 2020 · 2 comments · Fixed by #562
Closed

Debug impl of Fp outputs elements in Montgomery form. #76

Pratyush opened this issue Jun 19, 2020 · 2 comments · Fixed by #562
Labels
D-easy Difficulty: easy help wanted Extra attention is needed P-medium Priority: medium T-design Type: discuss API design and/or research T-feature Type: new features

Comments

@Pratyush
Copy link
Member

This can trip up users. Should we change this?
@Pratyush Pratyush transferred this issue from arkworks-rs/snark Nov 20, 2020
@Pratyush Pratyush added T-feature Type: new features D-easy Difficulty: easy help wanted Extra attention is needed labels Nov 20, 2020
@Pratyush Pratyush added P-medium Priority: medium T-design Type: discuss API design and/or research labels Sep 9, 2021
@jmcph4
Copy link

jmcph4 commented Dec 25, 2022

@Pratyush Status on this? Just got pinged in Discord and curious as to your suggested approach.

@Pratyush
Copy link
Member Author

The simplest thing to do would be to invoke into_bigint in the Debug impl

This was referenced Dec 26, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D-easy Difficulty: easy help wanted Extra attention is needed P-medium Priority: medium T-design Type: discuss API design and/or research T-feature Type: new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use into_bigint() in Debug for Fp<P, N> achimcc/algebra
Debug montgomery achimcc/algebra
2 participants
@jmcph4 @Pratyush