Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to_bytes to bigint #166

Merged
merged 11 commits into from
Jan 7, 2021
+57 −12
Merged

Add to_bytes to bigint #166

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
774aa1c
Add to_bytes to bigint
ValarDragon Jan 6, 2021
d20c4b6
Fix lint + changelog
ValarDragon Jan 6, 2021
1a25434
Fix comments
ValarDragon Jan 6, 2021
56bd59e
Update to_bits per pratyush's suggestion
ValarDragon Jan 6, 2021
dc422ab
Switch to *_be, *_le API
ValarDragon Jan 7, 2021
902e51d
Fix lint
ValarDragon Jan 7, 2021
dfd26c6
Update ff/src/biginteger/macros.rs
ValarDragon Jan 7, 2021
f7b87cb
move to_bits to default impl
ValarDragon Jan 7, 2021
84f2c6b
Merge branch 'bigint_to_bytes' of github.com:arkworks-rs/algebra into…
ValarDragon Jan 7, 2021
2926b91
Fix ec usage of to_bits
ValarDragon Jan 7, 2021
2237bb9
Apply suggestion
ValarDragon Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ec/src/msm/fixed_base.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ impl FixedBaseMSM {
scalar: &T::ScalarField,
) -> T {
let modulus_size = <T::ScalarField as PrimeField>::Params::MODULUS_BITS as usize;
let mut scalar_val = scalar.into_repr().to_bits();
let mut scalar_val = scalar.into_repr().to_bits_be();
scalar_val.reverse();
ValarDragon marked this conversation as resolved.
Show resolved Hide resolved

let mut res = multiples_of_g[0][0].into_projective();
Expand Down
4 changes: 2 additions & 2 deletions ff/src/biginteger/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ pub trait BigInteger:
/// with leading zeros.
fn to_bytes_be(&self) -> Vec<u8>;

/// Returns the byte representation in a big endian byte array,
/// with leading zeros.
/// Returns the byte representation in a little endian byte array,
/// with trailing zeros.
fn to_bytes_le(&self) -> Vec<u8>;

/// Returns a vector for wnaf.
Expand Down