Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ec:msm:{Fixed,Variable}Base:msm_checked_len #348

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

vlopes11
Copy link
Member

@vlopes11 vlopes11 commented Nov 16, 2021

Description

Add the new methods for checked fixed and variable base multi-scalar
multiplication. They will return None if the arguments don't have the
same length.

This way, the users may confidently call this function without having to
check the length themselves.

Also, ec:msm:{Fixed,Variable}BaseMSM was renamed to
ec:msm::{Fixed,Variable}Base to avoid redundancy. The import path
contained msm several times, and now it contains only one incidence
for the type resolution and one for the function call.

Closes #319


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@vlopes11 vlopes11 self-assigned this Nov 16, 2021
Add the new methods for checked fixed and variable base multi-scalar
multiplication. They will return `None` if the arguments don't have the
same length.

This way, the users may confidently call this function without having to
check the length themselves.

Also, `ec:msm:{Fixed,Variable}BaseMSM` was renamed to
`ec:msm::{Fixed,Variable}Base` to avoid redundancy. The import path
contained `msm` several times, and now it contains only one incidence
for the type resolution and one for the function call.

Closes #319
@vlopes11 vlopes11 force-pushed the vlopes11/319-multi-scalar-result branch from 926d305 to aa8540c Compare November 16, 2021 19:12
@vlopes11 vlopes11 requested a review from Pratyush November 16, 2021 19:13
@Pratyush Pratyush added breaking-change This PR contains a breaking change T-design Type: discuss API design and/or research T-refactor Type: cleanup/refactor labels Nov 16, 2021
@Pratyush Pratyush merged commit e554fa2 into master Nov 16, 2021
@Pratyush Pratyush deleted the vlopes11/319-multi-scalar-result branch November 16, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This PR contains a breaking change T-design Type: discuss API design and/or research T-refactor Type: cleanup/refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiscalar multiplication doesn't enforce lengths of input vectors
2 participants