Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mul<ScalarField> for Affine #449

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Add Mul<ScalarField> for Affine #449

merged 1 commit into from
Aug 4, 2022

Conversation

Pratyush
Copy link
Member

@Pratyush Pratyush commented Aug 4, 2022 •
edited
Loading

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

mmaker
mmaker approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@mmaker mmaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pratyush Pratyush requested a review from weikengchen August 4, 2022 18:20
@Pratyush Pratyush merged commit ddc708d into master Aug 4, 2022
@Pratyush Pratyush deleted the mul-for-affine branch August 4, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaker mmaker mmaker approved these changes

@weikengchen weikengchen Awaiting requested review from weikengchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pratyush @mmaker