Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE YET. Release 0.4 #512

Merged
merged 42 commits into from
Dec 28, 2022
Merged

DO NOT MERGE YET. Release 0.4 #512

merged 42 commits into from
Dec 28, 2022

Conversation

mmagician
Copy link
Member

Description

See comments in the makefile for the proposed process of doing releases.

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@mmagician mmagician marked this pull request as ready for review November 6, 2022 13:03
@mmagician mmagician requested review from a team as code owners November 6, 2022 13:03
@mmagician mmagician requested review from weikengchen and removed request for a team November 6, 2022 13:03
@mmagician
Copy link
Member Author

I have a slightly pedantic comment regarding this current approach actually: it would be nice if the commit where a tag was created from matched the one on master, e.g. like the releases in RustCrypto RSA. Currently due to a merge commit, this isn´t happening and the tag's commit is on a release branch only.

I would propose a 2-step release, kind of like outlined here: crate-ci/cargo-release#119

With some changes #54 & #53 to release-pr, it should be possible to add an action to the workflows and automate the first step of the release process. The second step should then be easy to automate too, but initially can be a manual run of (an adapted) make release.

@weikengchen
Copy link
Member

Let me fix the side effect of my incorrect git force push...

@weikengchen
Copy link
Member

OK. The side effect has been fixed.

@weikengchen weikengchen changed the title Release 0.4 DO NOT MERGE YET. Release 0.4 Dec 13, 2022
@weikengchen
Copy link
Member

(Added the "DO NOT MERGE YET" to prevent incidental merge. I believe that for now this is a tracking PR, and we will merge it to master when everything is finalized.)

@mmagician mmagician merged commit 2886a3b into master Dec 28, 2022
@mmagician mmagician deleted the release-0.4 branch December 28, 2022 15:04
@mmagician mmagician restored the release-0.4 branch December 28, 2022 15:12
andrewmilson added a commit to andrewmilson/algebra that referenced this pull request Jan 1, 2023
@andrewmilson
Merge remote-tracking branch 'upstream/master' into vec-allocator
c36601e 
* upstream/master: (29 commits)
  Fix some clippy lints (arkworks-rs#570)
  Correct tag name & complete command suggestion (arkworks-rs#569)
  Open a "release-PR" against a `releases` branch (arkworks-rs#566)
  Allow to overwrite default impl of `msm` in TwistedEdwards form (arkworks-rs#567)
  Remove poly-benches. (arkworks-rs#558)
  DO NOT MERGE YET. Release 0.4 (arkworks-rs#512)
  otherwise downstream users that have not migrated will not see warning (arkworks-rs#563)
  use `into_bigint()` in `Debug` for `Fp<P, N>` (arkworks-rs#562)
  Add `frobenius_map_in_place` (arkworks-rs#557)
  Fix test_sw_properties for some cofactor groups (arkworks-rs#555)
  Move h2c tests to test-templates (arkworks-rs#554)
  impl `CanonicalSerialize/Deserialize` for `BigUint` (arkworks-rs#551)
  Fix MontFp issue in fields with 64 * k bits (arkworks-rs#550)
  Fix tests for Modulus plus one div four (arkworks-rs#552)
  fix (arkworks-rs#547)
  Rename all `*Parameters` to `*Config` (arkworks-rs#545)
  Fix doc-comment on `SWUMap` and CamelCase `(CO)DOMAIN`
  Small cleanups in hash-to-curve (arkworks-rs#544)
  Allow to overwrite the default implementation of `msm` (arkworks-rs#528)
  Move `multi_miller_loop` and `final_exponentiation` into `BW6Config` (arkworks-rs#542)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weikengchen weikengchen weikengchen approved these changes

@Pratyush Pratyush Pratyush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmagician @weikengchen @Pratyush