Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frobenius_map_in_place #557

Merged
merged 2 commits into from
Dec 24, 2022
Merged

Add frobenius_map_in_place #557

merged 2 commits into from
Dec 24, 2022

Conversation

Pratyush
Copy link
Member

Description

This makes frobenius_map consistent with other methods like square_in_place, double_in_place, etc.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@Pratyush Pratyush requested review from a team as code owners December 24, 2022 05:44
@Pratyush Pratyush requested review from mmagician and weikengchen and removed request for a team December 24, 2022 05:44
@Pratyush Pratyush added T-refactor Type: cleanup/refactor breaking-change This PR contains a breaking change labels Dec 24, 2022
@alexander-zw alexander-zw changed the title Add frobenius_map_in-place Add frobenius_map_in_place Dec 24, 2022
alexander-zw
alexander-zw reviewed Dec 24, 2022
View reviewed changes
Copy link
Collaborator

@alexander-zw alexander-zw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to add any unit tests for the non-in place frobenius_map? Also update the changelog?

Also are we going to have to update curves for compatibility too

@Pratyush
Copy link
Member Author

Added, thanks!

@Pratyush Pratyush force-pushed the add-frobenius-map-in-place branch from 7f8908f to 15da95e Compare December 24, 2022 06:07
@Pratyush Pratyush mentioned this pull request Dec 24, 2022
Merged
6 tasks
@Pratyush Pratyush merged commit b770f67 into master Dec 24, 2022
@Pratyush Pratyush deleted the add-frobenius-map-in-place branch December 24, 2022 06:40
@mmagician mmagician mentioned this pull request Dec 28, 2022
Merged
6 tasks
andrewmilson added a commit to andrewmilson/algebra that referenced this pull request Jan 1, 2023
@andrewmilson
Merge remote-tracking branch 'upstream/master' into vec-allocator
c36601e 
* upstream/master: (29 commits)
  Fix some clippy lints (arkworks-rs#570)
  Correct tag name & complete command suggestion (arkworks-rs#569)
  Open a "release-PR" against a `releases` branch (arkworks-rs#566)
  Allow to overwrite default impl of `msm` in TwistedEdwards form (arkworks-rs#567)
  Remove poly-benches. (arkworks-rs#558)
  DO NOT MERGE YET. Release 0.4 (arkworks-rs#512)
  otherwise downstream users that have not migrated will not see warning (arkworks-rs#563)
  use `into_bigint()` in `Debug` for `Fp<P, N>` (arkworks-rs#562)
  Add `frobenius_map_in_place` (arkworks-rs#557)
  Fix test_sw_properties for some cofactor groups (arkworks-rs#555)
  Move h2c tests to test-templates (arkworks-rs#554)
  impl `CanonicalSerialize/Deserialize` for `BigUint` (arkworks-rs#551)
  Fix MontFp issue in fields with 64 * k bits (arkworks-rs#550)
  Fix tests for Modulus plus one div four (arkworks-rs#552)
  fix (arkworks-rs#547)
  Rename all `*Parameters` to `*Config` (arkworks-rs#545)
  Fix doc-comment on `SWUMap` and CamelCase `(CO)DOMAIN`
  Small cleanups in hash-to-curve (arkworks-rs#544)
  Allow to overwrite the default implementation of `msm` (arkworks-rs#528)
  Move `multi_miller_loop` and `final_exponentiation` into `BW6Config` (arkworks-rs#542)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-zw alexander-zw alexander-zw left review comments

@weikengchen weikengchen weikengchen approved these changes

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
breaking-change This PR contains a breaking change T-refactor Type: cleanup/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pratyush @weikengchen @alexander-zw