Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialize_to_vec! convenience macro #693

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

rozbb
Copy link
Contributor

@rozbb rozbb commented Oct 26, 2023

Description

Added a serialize_to_vec! macro which operates how the to_bytes! macro used to. It serializes uncompressed (fewer performance surprises that way).


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@rozbb rozbb requested review from a team as code owners October 26, 2023 21:07
@rozbb rozbb requested review from Pratyush, mmagician and weikengchen and removed request for a team October 26, 2023 21:07
@burdges
Copy link
Contributor

burdges commented Oct 26, 2023

Almost unrealted, but ark_scale::iter_ark_to_ark_bytes avoids some redundant intermediate layers. I've not upstreamed it, since I figured we cared more than anyone else, but maybe it makes sense here.

@Pratyush Pratyush merged commit 1acf70c into arkworks-rs:master Oct 27, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants