Implementation of bitwise operations between BigInteger
#713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdvanegasm
requested review from
z-tech,
Pratyush and
mmagician
and removed request for
a team
|
in the unittests, any chance you could add some checks on the higher limbs (right now you're testing only on the least significant) and de morgan's law ? |
It's not clear to me that BigInteger should represent integers mod 2^(N*64), so I'm not ready to take responsability for supporting bitwise NOT in the API. I'm also not sure bitwise operations like >> and << should be treated differently.
mmaker
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Looks good to me now! A few notes copy-pasted from my commit message:
-
It's not clear to me that BigInteger should represent integers mod 2^(N*64), so I'm not ready to take responsability for supporting bitwise NOT in the API of BigInteger (it's however in BigInt)
-
I'm also not sure bitwise operations like >> should be treated differently. I think we should add support for Shr in the API and deprecate div2() and divn() perhaps in a different PR?
Can another maintainer can have a look at this?
z-tech
approved these changes
Dec 14, 2023
|
Thanks btw @hdvanegasm! |
Merged
This was referenced Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I implemented bitwise operations between BigInteger: AND, XOR, NOT, and OR. In the modifications, the trait BigInteger now implements the necessary traits to support the mentioned bitwise operations, and I included the implementations for those operations for the BigInt struct. Also, I wrote some tests for this functionality.
This PR doesn't close any issue. It's just a feature that I found missing in the library.