Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract out duplicated TIPA code into common functions #5

Open
Pratyush opened this issue Sep 15, 2020 · 1 comment
Open

Extract out duplicated TIPA code into common functions #5

Pratyush opened this issue Sep 15, 2020 · 1 comment

Comments

@Pratyush
Copy link
Member

The problem with using TIPA black-box as I am right now is that it attempts to calculate the structured KZG polynomial commitment proof for both left and right. We would want to extract the polynomial commitment proving and verification code from the main prove and verify methods, so that they can be called separately for left and right.

Then to do TIPA for left and a structured scalar message for right, we can first run GIPA using a PlaceholderCommitment that has null commitment keys and null commitments. Then run the TIPA polynomial commitment code on just left.

I haven't made this change yet, but commenting here to make note of this as a possible plan forward.

Originally posted by @nirvantyagi in #3 (comment)

@nirvantyagi
Copy link
Collaborator

This extraction has been done in a3b6609 and daa6b41 .

But as currently implemented, the placeholder commitment which represents the scalar value, is empty, which means that the scalar value is not included in the challenge generation for GIPA.

https://github.com/arkworks-rs/ripp/blob/master/ip_proofs/src/tipa/structured_scalar_message.rs#L39

Originally, the placeholder commitment would return the scalar message to ensure it was included in the challenge. However, this makes the placeholder commitment non-doubly-homomorphic and so when extending the structured scalar message implementation to work without trusted setup (for the transparent polynomial implementation), this was removed.

a3b6609#diff-05adfa33df4f8d9ee9d41d9117b48ec51cc5f296bbe2bedb5070f4ed853bbaddR52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants