The script get-armadactl leaves behind files README.md and MAINTAINERS.md

[csantanapr]

When following the quickstart instructions of armada-operator running make kind-all it runs make get-armadactl

This downloads the armdatactl copies to $HOME/bin/armadatctl but leaves 3 files behind making the git repo dirty

The files are:

• armadactl
• README.md
• MAINTAINERS.md

To reproduce:

git clone https://github.com/armadaproject/armada-operator
cd armada-operator
make get-armadactl

Now check the git status notice the 3 files

On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   MAINTAINERS.md
        modified:   README.md

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        armadactl

[briheet]

Seeing the script that triggers make get-armadactl that is this script , i can see they are using VERSION=v0.8.2 with a TODO

TODO: This is commented out due to an issue with release process. Until we fix integration tests run on release, we will use the hardcoded version v0.8.2
#VERSION=$(get_latest_release)
VERSION=v0.8.2

this version is causing the problem as when i ran the version as VERSION=v0.9.3 , it did not update the Maintainers or the Readme files or added the License file

i think the latest version solves this issue
i dont know the if the integration tests are fixed or not or else id make a pr

[dejanzele]

Hi,

I plan to address this next week.

Thanks for reporting the issues.

[dejanzele]

PR which partially fixes this for Quickstart in Operator - armadaproject/armada-operator#315