Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reinstate tinker edge r dts #7311

Merged
merged 1 commit into from
Sep 30, 2024
Merged

reinstate tinker edge r dts #7311

merged 1 commit into from
Sep 30, 2024

Conversation

Tonymac32
Copy link
Member

Description

bump to 6.11 simply disabled it without any corresponding changes to board config/etc, so re-enable it once offending (inert) dtsi include removed.

How Has This Been Tested?

build OK. boot NOK, however one can assume it's pre-existing condition since this and the previous change were only to the dts file. I may come back to check on it, or @ARC-MX can return to take a look as original contributor.

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Sep 29, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 11 Milestone: Fourth quarter release labels Sep 30, 2024
@Tonymac32 Tonymac32 merged commit 60f2ad0 into armbian:main Sep 30, 2024
2 checks passed
@Tonymac32 Tonymac32 deleted the Edge-R branch September 30, 2024 16:32
@rpardini
Copy link
Member

rpardini commented Oct 1, 2024

unfortunately

  [🐳|🔨]   Error: arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi:107.1-8 Label or path cpu_l0 not found
  [🐳|🔨]   Error: arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi:111.1-8 Label or path cpu_l1 not found
  [🐳|🔨]   Error: arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi:115.1-8 Label or path cpu_l2 not found
  [🐳|🔨]   Error: arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi:119.1-8 Label or path cpu_l3 not found
  [🐳|🔨]   Error: arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi:123.1-8 Label or path cpu_b0 not found
  [🐳|🔨]   Error: arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi:127.1-8 Label or path cpu_b1 not found
  [🐳|🔨]   Error: arch/arm64/boot/dts/rockchip/rk3399-opp.dtsi:131.1-5 Label or path gpu not found
  [🐳|🔨]   Error: arch/arm64/boot/dts/rockchip/rk3399pro-tinker-edge-r.dts:34.20-21 syntax error
  [🐳|🔨]   FATAL ERROR: Unable to parse input tree

which, makes no sense, unless the include is not inert in the end.

@Tonymac32
Copy link
Member Author

That's not part of the affected includes, and I had no error on my build. 👀. I'll double check, but you probably should too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

3 participants