Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Manager support for GridDeltaGenerator #258

Open
KingMahmud opened this issue Oct 29, 2024 · 2 comments
Open

Context Manager support for GridDeltaGenerator #258

KingMahmud opened this issue Oct 29, 2024 · 2 comments

Comments

@KingMahmud
Copy link

KingMahmud commented Oct 29, 2024

Description

Hi,
Its has been more than a year since Row, GridDeltaGenerator has been added but there has been no light on adding context manager support about them.
The original PR author had written and commented them down saying "doesn't work", if you could look into the matter it will save us a lot of times and less problematic codes.

https://github.com/arnaudmiribel/streamlit-extras/blob/main/src/streamlit_extras/grid/__init__.py#L51

@arnaudmiribel
Copy link
Owner

Hi @KingMahmud,

Its has been more than a year since Row, GridDeltaGenerator has been added but there has been no light on adding context manager support about them.

Thanks for following up. Right, context manager support for Row and GridDeltaGenerator would be great. I admit I've missed them a couple of times too. If you’re interested, contributions are always welcome—it’s OSS, after all! Appreciate your patience and interest!

if you could look into the matter it will save us a lot of times and less problematic codes.

Btw can you tell more about the limitations you encounter without context manager?

cc-ing @lukasmasuch who's the author, if they happen to have a quick suggestion for this

@lukasmasuch
Copy link
Collaborator

I remember that adding a context manager was a bit tricky based on the way it's currently built. Also, we are planning to ship new native layout commmands in Streamlit soon (probably the beginning of next year). And these will definitely also work via context manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants