Adding IO capture tools #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asaurus1
force-pushed
the
add-capture-utils
branch
from
26077f9
to
7542c61
Compare
|
@arnaudmiribel I think this is still waiting to build. Any updates? |
arnaudmiribel
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Hey @Asaurus1, apologies for the long delay before responding. I've been out for a while! This extra looks all great, congrats for your submission. I'm approving and merging this so it gets published in our next release 🎈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arnaudmiribel While I'm working on the query string stuff, here's some more utility functions for capturing stdout, stderr, and logs, and rendering them to the page. It's very helpful for when you have a script or CLI tool someone else gave you and you just want to render its output without rewriting all the internal
printcalls to direct to streamlit.I also had to patch up the streamlit_patches.py file to get the gallery to run on my system (I did confirm I was using the poetry-locked streamlit 1.15.1, so it was odd that some of the imports were broken). I can revert that change if you can confirm it breaks things for you and is therefore a problem with my install.
https://github.com/streamlit/streamlit/blob/release/1.15.1/lib/streamlit/runtime/scriptrunner/script_runner.py#L49