Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with vertical alignment for grid #203

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

lukasmasuch
Copy link
Collaborator

@lukasmasuch lukasmasuch commented Dec 4, 2023

This PR fixes an issue with the row & grid extras with the most recent version of Streamlit. The vertical alignment didn't work correctly anymore with those versions.

Closes #201

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for phenomenal-crepe-0effec ready!

Name Link
🔨 Latest commit f283450
🔍 Latest deploy log https://app.netlify.com/sites/phenomenal-crepe-0effec/deploys/6577246d1dd3f9000899d2db
😎 Deploy Preview https://deploy-preview-203--phenomenal-crepe-0effec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lukasmasuch lukasmasuch marked this pull request as ready for review December 5, 2023 22:32
Copy link
Owner

@arnaudmiribel arnaudmiribel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukasmasuch!

@arnaudmiribel
Copy link
Owner

You might as well add a version bump so we release that along!

@lukasmasuch
Copy link
Collaborator Author

@arnaudmiribel Oki, i bumped it to 0.3.6. But not sure if I did it correctly? I just manually updated the projects.toml.

Copy link
Owner

@arnaudmiribel arnaudmiribel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep ,all grea! Thanks @lukasmasuch

@arnaudmiribel arnaudmiribel merged commit 5db3c30 into main Dec 11, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Streamlit 1.29.0 breaks row vertical align options
2 participants