Fix proposal for Codesearch UI

[MaxRcd]

Hello Arnoud,

First thing. Thank you a lot for this irreplaceable extension. Thanks to all contributors as well.

I am using Codesearch extensively. Sometimes I'm looking into records that don't have a name which leads the Codesearch UI to crash because a value checking is missing in the code.

Error example:

Example payload returned by the search API with null names:

I have fixed the code for my own usage. Fixed code is here : MaxRcd@598c493

I would be happy to have it in the actual browser extension so that I don't need to pull and fix the Codesearch UI everytime you release something new.

Regards

[arnoudkooi]

Thanks would be good to get fixed.
Wouldn't (hit?.name || '(empty)' ).replace(/<\/?[^>]+(>|$)/g, "") fix it?

What does the second condition try to fix?

[MaxRcd]

Yes this is the short version. That seems fine to me since hit.name is only called once.

The second condition checks that hit.sysId and hit.matches are present. Like hit.name, their presence is assumed but not verified. If they are not present, there is no point in displaying the search result, hence the return statement. It's not a fix. it's more like a safety belt.

I will update the code with the short version.
Edit: here https://github.com/arnoudkooi/ServiceNow-Utils/compare/master...MaxRcd:ServiceNow-Utils:master?diff=unified&w=

[arnoudkooi]

Thanks, I'll add this in today's update. I don't have a strategy to check all property existence of existing API call payloads, so I'll leave that for now.