diff --git a/pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/experiment-details.component.html b/pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/experiment-details.component.html index a310a71c079..722ad0e1b93 100644 --- a/pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/experiment-details.component.html +++ b/pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/experiment-details.component.html @@ -13,22 +13,21 @@ - - + > - Couldn't find information for the underlying Trials. + Couldn't find any successful Trial. diff --git a/pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/experiment-details.component.ts b/pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/experiment-details.component.ts index 6bc1da5d077..3f78b14a161 100644 --- a/pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/experiment-details.component.ts +++ b/pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/experiment-details.component.ts @@ -110,7 +110,7 @@ export class ExperimentDetailsComponent implements OnInit, OnDestroy { const data = transformStringResponses(response); this.columns = data.types; this.details = this.parseTrialsDetails(data.details); - this.showGraph = true; + this.showGraph = this.showGraphF(response); }); this.backendService .getExperiment(this.name, this.namespace) @@ -184,7 +184,7 @@ export class ExperimentDetailsComponent implements OnInit, OnDestroy { const data = transformStringResponses(trials); this.columns = data.types; this.details = this.parseTrialsDetails(data.details); - this.showGraph = trials.split(/\r\n|\r|\n/).length > 1; + this.showGraph = this.showGraphF(trials); }); }), ); @@ -253,4 +253,10 @@ export class ExperimentDetailsComponent implements OnInit, OnDestroy { return StatusEnum.CREATED; } } + + private showGraphF(response: string): boolean { + if (!response.includes(',,') && response.includes('\n')) { + return true; + } + } } diff --git a/pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/experiment-details.module.ts b/pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/experiment-details.module.ts index ea7c9932950..ecee4f8d378 100644 --- a/pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/experiment-details.module.ts +++ b/pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/experiment-details.module.ts @@ -15,6 +15,7 @@ import { TrialsTableModule } from './trials-table/trials-table.module'; import { ExperimentOverviewModule } from './overview/experiment-overview.module'; import { ExperimentDetailsTabModule } from './details/experiment-details-tab.module'; import { ExperimentYamlModule } from './yaml/experiment-yaml.module'; +import { TrialsGraphEchartsModule } from './trials-graph-echarts/trials-graph-echarts.module'; @NgModule({ declarations: [ExperimentDetailsComponent], @@ -31,6 +32,7 @@ import { ExperimentYamlModule } from './yaml/experiment-yaml.module'; MatProgressSpinnerModule, ExperimentYamlModule, TitleActionsToolbarModule, + TrialsGraphEchartsModule ], exports: [ExperimentDetailsComponent], })