Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide test coverage for Option.kt (#2894) #2934

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Provide test coverage for Option.kt (#2894) #2934

merged 3 commits into from
Feb 21, 2023

Conversation

swdevsm
Copy link
Contributor

@swdevsm swdevsm commented Feb 16, 2023

This pull request adds a few tests for Option.kt (except of deprecated methods).

nomisRev
nomisRev approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution @swdevsm 🙌 🥳 Looks good to me!

@nomisRev nomisRev requested a review from a team February 18, 2023 07:03
@swdevsm
Copy link
Contributor Author

swdevsm commented Feb 18, 2023

@nomisRev, thanks for the opportunity to do it :)

franciscodr
franciscodr approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @swdevsm!

@nomisRev nomisRev merged commit d07f778 into arrow-kt:main Feb 21, 2023
@swdevsm swdevsm deleted the provide-test-coverage-for-option branch February 21, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomisRev nomisRev nomisRev approved these changes

@franciscodr franciscodr franciscodr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swdevsm @franciscodr @nomisRev