Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Sequence signatures and hygiene #2993

Merged
merged 17 commits into from
Mar 24, 2023
Merged

Conversation

gutiory
Copy link
Collaborator

@gutiory gutiory commented Mar 23, 2023

These are the main changes in this PR:

  • Add deprecation to methods
  • Rename some method parameters
  • Deprecate methods that return Sequence, but that actually are terminal. This is related to this issue
  • Deprecate other methods and fix replacements.
  • Resolve deprecation in Sequence tests.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2023

Kover Report

File Coverage [63.26%]
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Sequence.kt 63.26%
Total Project Coverage 43.60%

Copy link
Member

@serras serras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I've left a few comments.

Copy link
Collaborator

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gutiory!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants