Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better: Compatibility with faraday 2 #666

Merged
merged 14 commits into from
Sep 27, 2022

Conversation

ylecuyer
Copy link
Collaborator

Work in progress to get koala compatible with faraday 2

koala.gemspec Show resolved Hide resolved
@pomartel
Copy link

Is this still a WIP? Or is it stable enough that we can start using and testing it?

@bborn
Copy link

bborn commented Sep 20, 2022

☝️ same as @pomartel - just wondering if there are plans to merge this in, or if I should create my own fork.

@ylecuyer
Copy link
Collaborator Author

Afair I kept this PR on hold because I wanted to get ride of this warning in the test suite:

Unable to load adapter typhoeus, using Net::HTTP. NameError method `call' not defined in Faraday::Adapter::Typhoeus

https://github.com/arsduo/koala/blob/master/spec/support/koala_test.rb#L236

It looks like this adapter will never exist anyway https://github.com/typhoeus/faraday-typhoeus/blob/main/lib/faraday/adapter/my_adapter.rb so let just merge it and release a version without the restriction on faraday

@pomartel
Copy link

@ylecuyer I have been using this branch in prod with Faraday 2 for a few months now and no issues so far.

@ylecuyer
Copy link
Collaborator Author

@ylecuyer I have been using this branch in prod with Faraday 2 for a few months now and no issues so far.

Thanks for the feedback, I have also been pointed to https://github.com/dleavitt/faraday-typhoeus so we can fix both and have a release

# Conflicts:
#	lib/koala/http_service.rb
#	spec/cases/http_service_spec.rb
@ylecuyer ylecuyer changed the title WIP: Better: Compatibility with faraday 2 Better: Compatibility with faraday 2 Sep 27, 2022
@ylecuyer ylecuyer merged commit 7191d44 into arsduo:master Sep 27, 2022
@ylecuyer ylecuyer deleted the compatibility-with-faraday-2-yle branch September 27, 2022 21:33
@ylecuyer
Copy link
Collaborator Author

Thanks for your help and patience, I'll prepare the release it should be available soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants