-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better: Compatibility with faraday 2 #666
Better: Compatibility with faraday 2 #666
Conversation
Is this still a WIP? Or is it stable enough that we can start using and testing it? |
☝️ same as @pomartel - just wondering if there are plans to merge this in, or if I should create my own fork. |
Afair I kept this PR on hold because I wanted to get ride of this warning in the test suite:
https://github.com/arsduo/koala/blob/master/spec/support/koala_test.rb#L236 It looks like this adapter will never exist anyway https://github.com/typhoeus/faraday-typhoeus/blob/main/lib/faraday/adapter/my_adapter.rb so let just merge it and release a version without the restriction on faraday |
@ylecuyer I have been using this branch in prod with Faraday 2 for a few months now and no issues so far. |
Thanks for the feedback, I have also been pointed to https://github.com/dleavitt/faraday-typhoeus so we can fix both and have a release |
This reverts commit bec792c.
# Conflicts: # lib/koala/http_service.rb # spec/cases/http_service_spec.rb
Thanks for your help and patience, I'll prepare the release it should be available soon |
Work in progress to get koala compatible with faraday 2